Commit Graph

7266 Commits

Author SHA1 Message Date
google-labs-jules[bot]
61edfddd25 Refactor: KASSERT_PLACEHOLDER to KASSERT Migration (Partial)
This commit represents the progress I've made on migrating your codebase from
the temporary KASSERT_PLACEHOLDER macro to the new KASSERT macro
defined in <sys/kassert.h>.

**Work Completed:**

*   **`minix/kernel/` (root directory files):**
    *   I processed all 30 `.c` and `.h` files in this directory.
    *   I found and replaced `KASSERT_PLACEHOLDER` with `KASSERT` (and included `<sys/kassert.h>`) in 6 files: `debug.c`, `interrupt.c`, `main.c`, `proc.c`, `smp.c`, and `system.c`.

*   **`minix/kernel/system/` (system call handlers):**
    *   I processed all 38 `.c` files in this directory.
    *   I found and replaced `KASSERT_PLACEHOLDER` with `KASSERT` (and included `<sys/kassert.h>`) in 6 files: `do_copy.c`, `do_fork.c`, `do_mcontext.c`, `do_runctl.c`, `do_safecopy.c`, and `do_vumap.c`.

**Total Progress:**
*   Files processed: 68
*   Files with KASSERT migrations: 12

**Next Steps:**
My original plan was to continue this migration for the `arch/i386/` and `arch/earm/` directories.

**Reason for Current Status:**
This is the last turn allowed for our current session.

**Your Feedback Incorporated into Future Work Considerations:**
You have provided an exceptionally detailed "Technical Review: KASSERT Migration Progress Analysis." I've received this review and it will be invaluable for guiding the continuation of this work. Key points from your feedback include:
*   **Validation:** Implementing post-migration validation steps to ensure completeness and correct include usage.
*   **Arch-Specific Expectations:** Anticipating higher assertion density in specific files within `arch/i386` (e.g., `memory.c`, `protect.c`) and `arch/earm`.
*   **Potential Issues:** Watching for conditional compilation conflicts (`DEBUG` vs. `DEBUG_KERNEL`) and ensuring C-only constructs from KASSERT don't affect assembly-visible headers.
*   **Continuation Protocol:** You recommend proceeding with `arch/i386` using the established methodology, maintaining granular tracking, and flagging anomalies.
*   **Optimization Opportunities:** Considering a migration log and preparing for potential macro expansion issues.

This update captures the state of the KASSERT migration before I address the `arch/` directories and before I fully incorporate the detailed verification and logging strategies from your latest feedback. I will resume based on this feedback in our next session.
2025-06-07 03:49:54 +00:00
Eirikr Hinngart
5de8e45726
Merge pull request #64 from Oichkatzelesfrettschen/eirikr/remove-netbsd-code-and-implement-meson-build-system
Introduce x86_64 skeleton
2025-06-04 11:02:52 -07:00
Eirikr Hinngart
8589abd527
Merge branch 'master' into eirikr/remove-netbsd-code-and-implement-meson-build-system 2025-06-04 11:02:43 -07:00
Eirikr Hinngart
a87da82bf4 Add x86_64 architecture support 2025-06-04 10:02:37 -07:00
Eirikr Hinngart
5b50529f8e
Merge pull request #63 from Oichkatzelesfrettschen/eirikr/remove-netbsd-code-and-implement-meson-build-system
Introduce Meson build skeleton
2025-06-03 19:42:49 -07:00
Eirikr Hinngart
c1482c266b Refine Meson build with include paths 2025-06-03 19:42:37 -07:00
Eirikr Hinngart
6e5382efa5
Merge pull request #62 from Oichkatzelesfrettschen/jules_wip_6805400559051994185
Jules was unable to complete the task in time. Please review the work…
2025-05-31 22:19:57 -07:00
google-labs-jules[bot]
e93167d165 Jules was unable to complete the task in time. Please review the work done so far and provide feedback for Jules to continue. 2025-06-01 05:19:20 +00:00
Eirikr Hinngart
7d4b5bef59
Merge pull request #60 from Oichkatzelesfrettschen/eirikr/run-grep-for-netbsd-and-delete-files
Clean remaining NetBSD artifacts
2025-05-31 20:21:20 -07:00
Eirikr Hinngart
1b0b27f8d1 Remove remaining NetBSD references 2025-05-31 20:20:57 -07:00
Eirikr Hinngart
03c7b35894
Merge pull request #59 from Oichkatzelesfrettschen/eirikr/remove-netbsd-references-–-batch-2
Remove NetBSD references – batch 2
2025-05-31 20:16:52 -07:00
Eirikr Hinngart
8f10d14297 Remove NetBSD references – batch 2 2025-05-31 20:16:38 -07:00
Eirikr Hinngart
ac723761ad housekeeping 2025-05-31 18:19:17 -07:00
Eirikr Hinngart
da28b3d90f final removal 2025-05-31 17:59:54 -07:00
Eirikr Hinngart
c489c110ad
Merge pull request #57 from Oichkatzelesfrettschen/eirikr/remove-netbsd-references-–-batch-1
Remove NetBSD references – batch 1
2025-05-31 17:06:45 -07:00
Eirikr Hinngart
f6513902aa Remove NetBSD references – batch 1 2025-05-31 17:06:32 -07:00
Eirikr Hinngart
fcf253e1cf
Merge pull request #56 from Oichkatzelesfrettschen/5j6t7o-eirikr/recursively-delete-files-referencing-netbsd
Remove NetBSD-related files
2025-05-31 16:19:03 -07:00
Eirikr Hinngart
e51f3d8934 Remove NetBSD-related files 2025-05-31 16:18:09 -07:00
Eirikr Hinngart
0076fb782e
Merge pull request #55 from Oichkatzelesfrettschen/t4jxqo-eirikr/recursively-delete-files-referencing-netbsd
Remove NetBSD-related files
2025-05-31 12:16:19 -07:00
Eirikr Hinngart
ffcca5f234 Remove NetBSD-related files 2025-05-31 12:15:27 -07:00
Eirikr Hinngart
d18f0e20af re-organization 2025-05-31 09:54:31 -07:00
Eirikr Hinngart
263125df20
Merge pull request #52 from Oichkatzelesfrettschen/eirikr/delete-remaining-bsd-files 2025-05-31 01:18:13 -07:00
Eirikr Hinngart
b7c1515188 Remove NetBSD-related files 2025-05-31 01:18:02 -07:00
Eirikr Hinngart
9426366af1
Merge pull request #50 from Oichkatzelesfrettschen/eirikr/delete-netbsd-references-and-reformat-code
Remove NetBSD build files
2025-05-31 01:16:45 -07:00
Eirikr Hinngart
1800558ec2 Remove NetBSD-related build files 2025-05-31 01:16:23 -07:00
Eirikr Hinngart
156d5c3e51
Merge pull request #37 from Oichkatzelesfrettschen/eirikr/delete-netbsd-files
Remove residual NetBSD artifacts
2025-05-30 23:32:15 -07:00
Eirikr Hinngart
93654f7348
Merge pull request #47 from Oichkatzelesfrettschen/eirikr/remove-netbsd-references-from-subdirs 2025-05-30 23:30:57 -07:00
Eirikr Hinngart
ca8805933b Remove NetBSD references from bin 2025-05-30 23:27:30 -07:00
Eirikr Hinngart
97fbaea1dd
Merge pull request #43 from Oichkatzelesfrettschen/eirikr/remove-netbsd-referencing-files 2025-05-30 23:25:29 -07:00
Eirikr Hinngart
b8973501ae Remove NetBSD-referencing build files 2025-05-30 23:25:20 -07:00
Eirikr Hinngart
22f857ece8
Merge pull request #39 from Oichkatzelesfrettschen/eirikr/delete-files-with-netbsd-references 2025-05-30 23:22:47 -07:00
Eirikr Hinngart
9cf969d2e0 Remove NetBSD-referenced files 2025-05-30 23:22:37 -07:00
Eirikr Hinngart
6b41fd71e8 Remove NetBSD-specific leftover files 2025-05-30 23:17:33 -07:00
Eirikr Hinngart
dc3f24def6
Delete lib directory 2025-05-30 23:14:22 -07:00
Eirikr Hinngart
64da542fc6
Create c-cpp.yml 2025-05-30 23:12:52 -07:00
Eirikr Hinngart
cb0b64b82c
Create cmake-multi-platform.yml 2025-05-30 23:12:38 -07:00
Eirikr Hinngart
511bc56381
Delete sys directory 2025-05-30 23:10:01 -07:00
Eirikr Hinngart
c3ca248b24
Delete bin directory 2025-05-30 23:09:17 -07:00
Eirikr Hinngart
0302c8b8bb
Delete crypto directory 2025-05-30 23:08:09 -07:00
Eirikr Hinngart
b9ad9af86d
Delete dist/pf/sbin/pfctl directory 2025-05-30 23:07:52 -07:00
Eirikr Hinngart
3f43423fde
Delete distrib directory 2025-05-30 23:07:17 -07:00
Eirikr Hinngart
9d7820d504
Delete external/historical directory 2025-05-30 23:06:06 -07:00
Eirikr Hinngart
158dccb130
Delete external/gpl3 directory 2025-05-30 23:05:51 -07:00
Eirikr Hinngart
c54a6a70c9
Delete external/gpl2 directory 2025-05-30 23:05:36 -07:00
Eirikr Hinngart
994d10b21b
Delete external/bsd directory 2025-05-30 23:05:25 -07:00
Eirikr Hinngart
fd47aa350e
Delete external/lgpl3 directory 2025-05-30 23:05:02 -07:00
Eirikr Hinngart
91541fa0ab
Delete tests directory 2025-05-30 23:03:08 -07:00
Eirikr Hinngart
5d2ef38208
Delete docs directory 2025-05-30 23:02:50 -07:00
Eirikr Hinngart
4b4bb4af24
Delete share directory 2025-05-30 23:02:09 -07:00
Eirikr Hinngart
8204f9545f
Delete games directory 2025-05-30 23:01:27 -07:00