fix condition to perform bpb evaluation (#324)

Co-authored-by: svlandeg <svlandeg@github.com>
This commit is contained in:
Nitish Pandey 2026-01-17 08:26:43 +05:30 committed by GitHub
parent e1dafc510f
commit f42ae9e901
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -249,7 +249,7 @@ while True:
last_step = bool(last_step_tensor.item())
# once in a while: evaluate the val bpb (all ranks participate)
if args.eval_every > 0 and (last_step or step % args.eval_every == 0):
if last_step or (args.eval_every > 0 and step % args.eval_every == 0):
model.eval()
val_loader = build_val_loader()
eval_steps = args.eval_tokens // (args.device_batch_size * args.max_seq_len * ddp_world_size)