tacit/nanochat
1
0
Fork 0
mirror of https://github.com/karpathy/nanochat.git synced 2026-03-25 14:15:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Replace speedup assertion with warning in batch_encode test

Browse Source 
Performance varies by machine and load, making hard assertions flaky.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Andrej Karpathy 2025-12-28 04:10:49 +00:00
parent 7a8769a40c
commit 91d76cc690
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/test_rustbpe.py
View File

@ -21,6 +21,7 @@ python -m pytest tests/test_rustbpe.py -v -s
import regex as re
from collections import Counter, defaultdict
import time
import warnings
import rustbpe
import tiktoken
import pytest
@ -712,5 +713,6 @@ def test_batch_encode_performance(enwik8_large):
print(f" Batch: {batch_time:.4f}s")
print(f" Speedup: {speedup:.2f}x")
# Assert meaningful speedup (at least 1.5x on multi-core)
assert speedup > 1.5, f"Expected >1.5x speedup, got {speedup:.2f}x"
# Warn if speedup is low (can vary by machine/load)
if speedup < 1.5:
warnings.warn(f"batch_encode() speedup was only {speedup:.2f}x (expected >1.5x)")