tacit/nanochat
1
0
Fork 0
mirror of https://github.com/karpathy/nanochat.git synced 2025-12-06 04:12:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Replace fcntl with filelock for Windows compatibility

Browse Source
This commit is contained in:
Andrej 2025-11-04 16:35:39 -08:00 committed by GitHub
commit 885a4f25e7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
nanochat/common.py
View File

@ -5,10 +5,10 @@ Common utilities for nanochat.
import os import os
import re import re
import logging import logging
import fcntl
import urllib.request import urllib.request
import torch import torch
import torch.distributed as dist import torch.distributed as dist
from filelock import FileLock
class ColoredFormatter(logging.Formatter): class ColoredFormatter(logging.Formatter):
"""Custom formatter that adds colors to log messages.""" """Custom formatter that adds colors to log messages."""
@ -70,13 +70,11 @@ def download_file_with_lock(url, filename, postprocess_fn=None):
if os.path.exists(file_path): if os.path.exists(file_path):
return file_path return file_path
with open(lock_path, 'w', encoding='utf-8') as lock_file: with FileLock(lock_path):
# Only a single rank can acquire this lock # Only a single rank can acquire this lock
# All other ranks block until it is released # All other ranks block until it is released
fcntl.flock(lock_file.fileno(), fcntl.LOCK_EX)
# Recheck after acquiring lock (another process may have downloaded it) # Recheck after acquiring lock
if os.path.exists(file_path): if os.path.exists(file_path):
return file_path return file_path
@ -94,12 +92,6 @@ def download_file_with_lock(url, filename, postprocess_fn=None):
if postprocess_fn is not None: if postprocess_fn is not None:
postprocess_fn(file_path) postprocess_fn(file_path)
# Clean up the lock file after the lock is released
try:
os.remove(lock_path)
except OSError:
pass # Ignore if already removed by another process
return file_path return file_path
def print0(s="",**kwargs): def print0(s="",**kwargs):