tacit/nanochat
1
0
Fork 0
mirror of https://github.com/karpathy/nanochat.git synced 2026-05-10 09:50:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(frontend): pass assistantMsgId directly to fix stale closure bug

Browse Source
This commit is contained in:
Manmohan Sharma 2026-04-16 15:15:53 -07:00
parent a873b6ad46
commit 16f40ceb54
No known key found for this signature in database
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
services/frontend/components/chat/ChatWindow.tsx
View File

@ -60,7 +60,7 @@ export default function ChatWindow() {
setIsStreaming(false);
}, []);
const streamFromApi = useCallback(async (convId: string, content: string, temp?: number, topk?: number) => {
const streamFromApi = useCallback(async (convId: string, assistantMsgId: string, content: string, temp?: number, topk?: number) => {
stop();
const ac = new AbortController();
abortRef.current = ac;
@ -110,9 +110,7 @@ export default function ChatWindow() {
}
if (typeof data.token === 'string') {
streamingBufferRef.current += data.token;
if (streamingMsgId && convId) {
updateMessage(convId, streamingMsgId!, streamingBufferRef.current);
}
updateMessage(convId, assistantMsgId, streamingBufferRef.current);
}
} catch { /* skip malformed */ }
}
@ -123,8 +121,8 @@ export default function ChatWindow() {
} catch (err) {
if ((err as Error).name !== 'AbortError') {
console.error('[chat] stream error:', err);
if (streamingMsgId && currentConversationId) {
updateMessage(currentConversationId, streamingMsgId!, `Error: ${(err as Error).message}`);
if (assistantMsgId && convId) {
updateMessage(convId, assistantMsgId, `Error: ${(err as Error).message}`);
}
}
setStreamingMsgId(null);
@ -133,7 +131,7 @@ export default function ChatWindow() {
setIsStreaming(false);
abortRef.current = null;
}
}, [stop, streamingMsgId, currentConversationId, updateMessage]);
}, [stop, updateMessage]);
const ensureConversation = useCallback(async () => {
if (currentConversationId) return currentConversationId;
@ -174,7 +172,7 @@ export default function ChatWindow() {
setStreamingMsgId(assistantId);
streamingBufferRef.current = '';
await streamFromApi(convId, text, temperature, topK);
await streamFromApi(convId, assistantId, text, temperature, topK);
},
[
draft,