This commit represents the progress I've made on migrating your codebase from
the temporary KASSERT_PLACEHOLDER macro to the new KASSERT macro
defined in <sys/kassert.h>.
**Work Completed:**
* **`minix/kernel/` (root directory files):**
* I processed all 30 `.c` and `.h` files in this directory.
* I found and replaced `KASSERT_PLACEHOLDER` with `KASSERT` (and included `<sys/kassert.h>`) in 6 files: `debug.c`, `interrupt.c`, `main.c`, `proc.c`, `smp.c`, and `system.c`.
* **`minix/kernel/system/` (system call handlers):**
* I processed all 38 `.c` files in this directory.
* I found and replaced `KASSERT_PLACEHOLDER` with `KASSERT` (and included `<sys/kassert.h>`) in 6 files: `do_copy.c`, `do_fork.c`, `do_mcontext.c`, `do_runctl.c`, `do_safecopy.c`, and `do_vumap.c`.
**Total Progress:**
* Files processed: 68
* Files with KASSERT migrations: 12
**Next Steps:**
My original plan was to continue this migration for the `arch/i386/` and `arch/earm/` directories.
**Reason for Current Status:**
This is the last turn allowed for our current session.
**Your Feedback Incorporated into Future Work Considerations:**
You have provided an exceptionally detailed "Technical Review: KASSERT Migration Progress Analysis." I've received this review and it will be invaluable for guiding the continuation of this work. Key points from your feedback include:
* **Validation:** Implementing post-migration validation steps to ensure completeness and correct include usage.
* **Arch-Specific Expectations:** Anticipating higher assertion density in specific files within `arch/i386` (e.g., `memory.c`, `protect.c`) and `arch/earm`.
* **Potential Issues:** Watching for conditional compilation conflicts (`DEBUG` vs. `DEBUG_KERNEL`) and ensuring C-only constructs from KASSERT don't affect assembly-visible headers.
* **Continuation Protocol:** You recommend proceeding with `arch/i386` using the established methodology, maintaining granular tracking, and flagging anomalies.
* **Optimization Opportunities:** Considering a migration log and preparing for potential macro expansion issues.
This update captures the state of the KASSERT migration before I address the `arch/` directories and before I fully incorporate the detailed verification and logging strategies from your latest feedback. I will resume based on this feedback in our next session.
112 lines
3.7 KiB
Plaintext
112 lines
3.7 KiB
Plaintext
minix/kernel/arch/earm/arch_clock.c
|
|
minix/kernel/arch/earm/arch_do_vmctl.c
|
|
minix/kernel/arch/earm/arch_reset.c
|
|
minix/kernel/arch/earm/arch_system.c
|
|
minix/kernel/arch/earm/bsp/include/bsp_init.h
|
|
minix/kernel/arch/earm/bsp/include/bsp_intr.h
|
|
minix/kernel/arch/earm/bsp/include/bsp_padconf.h
|
|
minix/kernel/arch/earm/bsp/include/bsp_reset.h
|
|
minix/kernel/arch/earm/bsp/include/bsp_serial.h
|
|
minix/kernel/arch/earm/bsp/include/bsp_timer.h
|
|
minix/kernel/arch/earm/bsp/ti/omap_intr_registers.h
|
|
minix/kernel/arch/earm/bsp/ti/omap_rtc.h
|
|
minix/kernel/arch/earm/bsp/ti/omap_serial.c
|
|
minix/kernel/arch/earm/bsp/ti/omap_serial.h
|
|
minix/kernel/arch/earm/bsp/ti/omap_timer_registers.h
|
|
minix/kernel/arch/earm/exception.c
|
|
minix/kernel/arch/earm/include/arch_clock.h
|
|
minix/kernel/arch/earm/include/arch_proto.h
|
|
minix/kernel/arch/earm/include/arch_watchdog.h
|
|
minix/kernel/arch/earm/include/archconst.h
|
|
minix/kernel/arch/earm/include/ccnt.h
|
|
minix/kernel/arch/earm/include/cpufunc.h
|
|
minix/kernel/arch/earm/include/direct_utils.h
|
|
minix/kernel/arch/earm/include/hw_intr.h
|
|
minix/kernel/arch/earm/include/io.h
|
|
minix/kernel/arch/earm/memory.c
|
|
minix/kernel/arch/earm/pg_utils.c
|
|
minix/kernel/arch/earm/pre_init.c
|
|
minix/kernel/arch/earm/protect.c
|
|
minix/kernel/arch/i386/acpi.c
|
|
minix/kernel/arch/i386/acpi.h
|
|
minix/kernel/arch/i386/apic.c
|
|
minix/kernel/arch/i386/apic.h
|
|
minix/kernel/arch/i386/arch_clock.c
|
|
minix/kernel/arch/i386/arch_do_vmctl.c
|
|
minix/kernel/arch/i386/arch_reset.c
|
|
minix/kernel/arch/i386/arch_smp.c
|
|
minix/kernel/arch/i386/arch_system.c
|
|
minix/kernel/arch/i386/debugreg.h
|
|
minix/kernel/arch/i386/do_iopenable.c
|
|
minix/kernel/arch/i386/exception.c
|
|
minix/kernel/arch/i386/include/arch_clock.h
|
|
minix/kernel/arch/i386/include/arch_proto.h
|
|
minix/kernel/arch/i386/include/arch_smp.h
|
|
minix/kernel/arch/i386/include/arch_watchdog.h
|
|
minix/kernel/arch/i386/include/archconst.h
|
|
minix/kernel/arch/i386/include/direct_utils.h
|
|
minix/kernel/arch/i386/include/hw_intr.h
|
|
minix/kernel/arch/i386/memory.c
|
|
minix/kernel/arch/i386/oxpcie.c
|
|
minix/kernel/arch/i386/oxpcie.h
|
|
minix/kernel/arch/i386/pg_utils.c
|
|
minix/kernel/arch/i386/pre_init.c
|
|
minix/kernel/arch/i386/protect.c
|
|
minix/kernel/arch/i386/serial.h
|
|
minix/kernel/clock.c
|
|
minix/kernel/const.h
|
|
minix/kernel/debug.c
|
|
minix/kernel/debug.h
|
|
minix/kernel/ipc.h
|
|
minix/kernel/ipc_filter.h
|
|
minix/kernel/kernel.h
|
|
minix/kernel/main.c
|
|
minix/kernel/priv.h
|
|
minix/kernel/proc.h
|
|
minix/kernel/profile.c
|
|
minix/kernel/profile.h
|
|
minix/kernel/proto.h
|
|
minix/kernel/smp.c
|
|
minix/kernel/smp.h
|
|
minix/kernel/system/do_abort.c
|
|
minix/kernel/system/do_clear.c
|
|
minix/kernel/system/do_copy.c
|
|
minix/kernel/system/do_devio.c
|
|
minix/kernel/system/do_diagctl.c
|
|
minix/kernel/system/do_exec.c
|
|
minix/kernel/system/do_exit.c
|
|
minix/kernel/system/do_fork.c
|
|
minix/kernel/system/do_getinfo.c
|
|
minix/kernel/system/do_getksig.c
|
|
minix/kernel/system/do_irqctl.c
|
|
minix/kernel/system/do_kill.c
|
|
minix/kernel/system/do_mcontext.c
|
|
minix/kernel/system/do_privctl.c
|
|
minix/kernel/system/do_runctl.c
|
|
minix/kernel/system/do_safecopy.c
|
|
minix/kernel/system/do_safememset.c
|
|
minix/kernel/system/do_schedctl.c
|
|
minix/kernel/system/do_schedule.c
|
|
minix/kernel/system/do_setalarm.c
|
|
minix/kernel/system/do_setgrant.c
|
|
minix/kernel/system/do_settime.c
|
|
minix/kernel/system/do_sigreturn.c
|
|
minix/kernel/system/do_sigsend.c
|
|
minix/kernel/system/do_sprofile.c
|
|
minix/kernel/system/do_statectl.c
|
|
minix/kernel/system/do_stime.c
|
|
minix/kernel/system/do_times.c
|
|
minix/kernel/system/do_trace.c
|
|
minix/kernel/system/do_umap.c
|
|
minix/kernel/system/do_umap_remote.c
|
|
minix/kernel/system/do_update.c
|
|
minix/kernel/system/do_vdevio.c
|
|
minix/kernel/system/do_vmctl.c
|
|
minix/kernel/system/do_vtimer.c
|
|
minix/kernel/system/do_vumap.c
|
|
minix/kernel/system.c
|
|
minix/kernel/table.c
|
|
minix/kernel/type.h
|
|
minix/kernel/utility.c
|
|
minix/kernel/watchdog.c
|