tacit/minix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix off-by-one

Browse Source 
This change strengthens a bounds check to make sure no out of bound indexing occurs when using a port.
This commit is contained in:
Ilja van Sprundel 2019-10-06 20:31:18 +02:00 committed by GitHub
parent 37230bf0c3
commit 6d152649a3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
minix/drivers/usb/usb_hub/usb_hub.c
View File

@ -417,7 +417,7 @@ hub_task(void * UNUSED(arg))
HUB_DEBUG_MSG("bHubContrCurrent %4X", d->bHubContrCurrent);
/* Check for sane number of ports... */
if (d->bNbrPorts > USB_HUB_PORT_LIMIT) {
if (d->bNbrPorts >= USB_HUB_PORT_LIMIT) {
HUB_MSG("Too many hub ports declared: %d", d->bNbrPorts);
goto HUB_ERROR;
}