From 2f999e5753c7ad56e39a708aedd08365a02bc9ad Mon Sep 17 00:00:00 2001 From: Kees Jongenburger Date: Wed, 25 Sep 2013 11:12:46 +0200 Subject: [PATCH] arm:make the MMU fetch pagetable data through the caches. Change-Id: Ibd7b66558c369d0c0792c02801562580d255fa1f --- include/arch/earm/include/vm.h | 5 +++++ kernel/arch/earm/include/cpufunc.h | 10 +++++++--- kernel/arch/earm/memory.c | 2 +- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/include/arch/earm/include/vm.h b/include/arch/earm/include/vm.h index 98c155fc4..caa0c5663 100644 --- a/include/arch/earm/include/vm.h +++ b/include/arch/earm/include/vm.h @@ -163,6 +163,11 @@ arm/vm.h #define ARM_VM_PFE_FS4 (1<<10) /* Fault status (bit 4) */ #define ARM_VM_PFE_FS3_0 0xf /* Fault status (bits 3:0) */ + +/* Translation table base register specfic flags */ +#define TTBR_ADDR_MASK (0xffffc000) +#define TTBR_FLAGS_CACHED (0x1 << 3)| (0x1) + /* Fault status */ #define ARM_VM_PFE_FS(s) \ ((((s) & ARM_VM_PFE_FS4) >> 6) | ((s) & ARM_VM_PFE_FS3_0)) diff --git a/kernel/arch/earm/include/cpufunc.h b/kernel/arch/earm/include/cpufunc.h index d44f505b3..d45d17625 100644 --- a/kernel/arch/earm/include/cpufunc.h +++ b/kernel/arch/earm/include/cpufunc.h @@ -215,16 +215,20 @@ static inline u32_t read_ttbr0() asm volatile("mrc p15, 0, %[bar], c2, c0, 0 @ Read TTBR0\n\t" : [bar] "=r" (bar)); - return bar; + return bar & TTBR_ADDR_MASK; } /* Write Translation Table Base Register 0 */ static inline void write_ttbr0(u32_t bar) { barrier(); - + /* In our setup TTBR contains the base address *and* the flags + but other pieces of the kernel code expect ttbr to be the + base address of the l1 page table. We therefore add the + flags here and remove them in the read_ttbr0 */ + u32_t v = (bar & TTBR_ADDR_MASK ) | TTBR_FLAGS_CACHED; asm volatile("mcr p15, 0, %[bar], c2, c0, 0 @ Write TTBR0\n\t" - : : [bar] "r" (bar)); + : : [bar] "r" (v)); refresh_tlb(); } diff --git a/kernel/arch/earm/memory.c b/kernel/arch/earm/memory.c index ad61ace38..2e44eb5eb 100644 --- a/kernel/arch/earm/memory.c +++ b/kernel/arch/earm/memory.c @@ -303,7 +303,7 @@ int vm_lookup(const struct proc *proc, const vir_bytes virtual, assert(HASPT(proc)); /* Retrieve page directory entry. */ - root = (u32_t *) proc->p_seg.p_ttbr; + root = (u32_t *) (proc->p_seg.p_ttbr & TTBR_ADDR_MASK); assert(!((u32_t) root % ARM_PAGEDIR_SIZE)); pde = ARM_VM_PDE(virtual); assert(pde >= 0 && pde < ARM_VM_DIR_ENTRIES);